[PATCH] D118019: Implement correct cost for SVE bitcasts

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Looks like a nice improvement @alban.bridonneau! Just had one minor comment on the tests ...



================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-bitcast.ll:10
+
+define <vscale x 2 x half> @test_nxv2i16(<vscale x 2 x i16> %a) {
+; CHECK-LABEL: test_nxv2i16
----------------
Hi @alban.bridonneau, I think it's also worth adding tests for the inverse case i.e. bitcast <vscale x 2 x half> -> bitcast <vscale x 2 x i16>. The operations should also be free I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118019/new/

https://reviews.llvm.org/D118019