[PATCH] D86617: [GlobalISel][TableGen] Take first result for multi-output instructions

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Reverse ping!

This is definitely useful for enabling more AMDGPU patterns to be imported.

@arsenm wrote:

> I mostly see this as making the behavior more opaque by changing based on the specific register classes involved, so I'm not in favor.

I don't understand this objection. How does it depend on specific register classes? How is this patch morally different from ee3feef5aaaa <https://reviews.llvm.org/rGee3feef5aaaa3c385fbe08bdb2d48829ad440b56> which did the same thing at the top level of a pattern?

Summary:

> situations are handled in SelectionIDAG.

Typo "SelectionDAG"



================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3474
+  // If there are multiple results, just take the first one (this is how
+  // SelectionIDAG does it).
   Optional<LLTCodeGen> MaybeOpTy;
----------------
Typo "SelectionDAG"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86617/new/

https://reviews.llvm.org/D86617