[PATCH] D117803: [PowerPC] Update handling of splat loads for v4i32/v4f32/v2i64 to require non-extending loads.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 02:10:19 PST 2022


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM other than a small nit.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9108
+  // For v8i16 and v16i8 types, extending loads can be handled as long as the
+  // memory VT width is the same vector element VT type.
+  // The loads feeding into the v8i16 and v16i8 types will be extending because
----------------
The word `width` here is out of place. We are not checking the width but the actual type so you can simply remove that word.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117803/new/

https://reviews.llvm.org/D117803



More information about the llvm-commits mailing list