[PATCH] D118094: [InstCombine] Implementing (x & y) + ~(x | y) -> ~(x ^ y)

Tue Jan 25 00:55:53 PST 2022

xbolva00 added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/pr53357.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; Test for (x & y) + ~(x | y) -> ~(x ^ y)
----------------
ChuanqiXu wrote:
> ChuanqiXu wrote:
> > nikic wrote:
> > > The check lines don't look like update_test_checks output.
> > My bad, I just copied this one from other tests. Do you think what should I do? Remove this one simply?
> I found several tests contain the line. For example: https://github.com/llvm/llvm-project/commit/732a90da785de2f61dbbf09d6c5fe55937d194b6 and https://github.com/llvm/llvm-project/commit/fc8f1e4419d338a347bade7cfc76f73052f00739. And I add it for consistency. Do you think we need to remove them?
You should remove current checks and use that script to generate them properly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118094/new/

https://reviews.llvm.org/D118094