[PATCH] D118090: [ScalarEvolution] Handle <= and >= in non infinite loops
    Nikita Popov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jan 25 00:54:57 PST 2022
    
    
  
nikic added a reviewer: reames.
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
Why does this add a FiniteLoops flag to SCEV, rather than using mustprogress attributes/metadata? I'm not convinced that should be added, and in either case this change is independent from the change to exit limit logic.
================
Comment at: llvm/unittests/Analysis/ScalarEvolutionTest.cpp:1750
 
+TEST_F(ScalarEvolutionsTest, ComputeTripForFiniteSLE) {
+  LLVMContext C;
----------------
Is there any particular reason these can't use normal `print<scalar-evolution>` tests? See various `llvm/test/Analysis/ScalarEvolution/trip-count*.ll` tests for example.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118090/new/
https://reviews.llvm.org/D118090
    
    
More information about the llvm-commits
mailing list