[PATCH] D116180: [InstrProf] Add single byte coverage mode

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

This change appears to be implementing `func-cov` mode proposed in https://groups.google.com/g/llvm-dev/c/r03Z6JoN7d4. Do you plan on implementing the support for `block-cov` and `func-cnt` modes as well? I'm asking because we're interested in the `block-cov` mode, but also because I'm somewhat concerned about the orthogonality of these modes in the implementation.

For example, this change introduces the `VARIANT_MASK_BYTE_ENTRY_COVERAGE` flag to track whether the `func-cov` mode is used. This means that we're going to need two more bits for `block-cov` and `func-cnt` (three in total). Wouldn't it make more sense to instead have `VARIANT_MASK_BYTE_COVERAGE` and `VARIANT_MASK_ENTRY_COVERAGE` flags which could be combined to represent all four modes, requiring only two bits in total?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116180/new/

https://reviews.llvm.org/D116180