[PATCH] D97129: [Support] unsafe pointer arithmetic in llvm_regcomp()
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 24 22:38:15 PST 2022
vitalybuka added a comment.
Can you please clang format according to premerge checks?
================
Comment at: llvm/lib/Support/regcomp.c:252
#define PEEK2() (*(p->next+1))
-#define MORE() (p->next < p->end)
-#define MORE2() (p->next+1 < p->end)
+#define MORE() (p->end - p->next > 0)
+#define MORE2() (p->end - p->next > 1)
----------------
I understand all but this line. I guess it had no UB there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97129/new/
https://reviews.llvm.org/D97129
More information about the llvm-commits
mailing list