[PATCH] D117386: github: Add actions to automate part of the release workflow

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked 8 inline comments as done.
tstellar added inline comments.


================
Comment at: .github/workflows/issue-release-workflow.yml:47
+        run:  |
+          curl -O -L https://raw.githubusercontent.com/$GITHUB_REPOSITORY/$GITHUB_SHA/llvm/utils/git/github-automation.py
+          chmod a+x github-automation.py
----------------
tstellar wrote:
> kwk wrote:
> > Why curl the file instead of cloning like before? If `github-automation.py` happens to need another file from the repo you'd have to remember to patch this place.
> I mainly did this because cloning is so slow.  I agree cloning would be better.  I will try to benchmark with a shallow clone to see how long it takes.
I dropped this, the shallow checkout seems to be fast enough.


================
Comment at: llvm/utils/git/github-automation.py:48
+    def __init__(self, args):
+        self.args = args
+        self.token = args.token
----------------
kwk wrote:
> I suggest to keep this "private": `self._args = args`
I removed self.args completely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117386/new/

https://reviews.llvm.org/D117386