[PATCH] D114342: ConvertUTF, new wrapper API
Michael Spencer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 24 17:39:42 PST 2022
Bigcheese added a comment.
In D114342#3267957 <https://reviews.llvm.org/D114342#3267957>, @tschuett wrote:
> I though modern LLVM is to return `llvm::Expected<std::string>`?!?
This is true, but this patch is matching the existing API. I don't like the current API, but I don't think this patch needs to fix that, and specifically shouldn't diverge from the existing API.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114342/new/
https://reviews.llvm.org/D114342
More information about the llvm-commits
mailing list