[PATCH] D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td

[Son Tuan Vu via Phabricator via llvm-commits]

tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:97-100
   default:
     // Anything not explicitly designated otherwise is a normal 4-byte insn.
     NumBytes = 4;
     break;
----------------
nickdesaulniers wrote:
> should this case become `llvm_unreachable` now?
Well, this is actually handling cases where the fixed constant size is not specified in .td file. I think the intention was to assume that a pseudo-instruction w/o specified size is always expanded to a 4-byte instruction. Is this correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117970/new/

https://reviews.llvm.org/D117970