[PATCH] D117586: [DebugInfo] Add stringLocationExp field to DIStringType

Chih-Ping Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 14:04:57 PST 2022


cchen15 added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/MetadataLoader.cpp:1426
   case bitc::METADATA_STRING_TYPE: {
-    if (Record.size() != 8)
+    if (Record.size() != 9)
       return error("Invalid record");
----------------
aprantl wrote:
> Would it be possible to load this in a backwards-compatible way, so old records of size 8 still work?
Thanks for pointing this out. It will be addressed in the next patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117586/new/

https://reviews.llvm.org/D117586



More information about the llvm-commits mailing list