[PATCH] D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 24 13:47:59 PST 2022
yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.
Exact spelling of the temporary test directory shouldn't matter.
The z/OS linker not being able to handle this sounds like a bug... but oh my.
Nit: can we make the comment more compact, maybe:
tmp_dir = tempfile.mkdtemp(prefix='lit-tmp-') # z/OS linker does not support '_' in paths, so use '-'
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118071/new/
https://reviews.llvm.org/D118071
More information about the llvm-commits
mailing list