[PATCH] D107355: [ptr_provenance] Introduce llvm.experimental.ptr.provenance

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:589
+    : DefaultAttrsIntrinsic<[llvm_anyptr_ty],
+                [LLVMMatchType<0>, llvm_anyptr_ty],
+                [IntrNoMem, IntrSpeculatable]>; // NOTE: Returned<0> must not be used here
----------------
IRBuilder asserts that both types are the same, so make the second one `LLVMMatchType<0>` as well?


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:590
+                [LLVMMatchType<0>, llvm_anyptr_ty],
+                [IntrNoMem, IntrSpeculatable]>; // NOTE: Returned<0> must not be used here
+
----------------
This can also be `NoCapture<ArgIndex<1>>` I believe. (The first argument is capturing, because the pointer is returned.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107355/new/

https://reviews.llvm.org/D107355