[PATCH] D118061: [InstCombine] fold one-bit set/clear icmp with mul operand

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.
The proof looks correct to me, but a fear that we are missing things due to extra artificial uses due to the preconditions has struck me before.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:1847
                                                    const APInt &C) {
   if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
     return I;
----------------
This fold should probably be in `foldICmpAndConstConst()`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118061/new/

https://reviews.llvm.org/D118061