[PATCH] D118059: [OpenMP][Fix] Properly inherit calling convention
Joseph Huber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 24 11:38:26 PST 2022
jhuber6 added a comment.
In D118059#3267079 <https://reviews.llvm.org/D118059#3267079>, @jdoerfert wrote:
> are there any other createCall calls we might need to update?
There are other locations we should probably include, places where we call `CallInst::Create` directly.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3245
+ CallInst *Tid =
OMPInfoCache.OMPBuilder.Builder.CreateCall(HardwareTidFn, {});
+ if (Function *Fn = dyn_cast<Function>(HardwareTidFn.getCallee()))
----------------
jdoerfert wrote:
> Unrelated: don't we need debug loc here too?
>
Could probably include it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118059/new/
https://reviews.llvm.org/D118059
More information about the llvm-commits
mailing list