[PATCH] D115419: [PowerPC] Allow absolute expressions in relocations

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 11:23:12 PST 2022


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Thanks @nemanjai . Consider cleaning up some whitespace nits in the newly added test before comitting.



================
Comment at: llvm/test/MC/PowerPC/ppc64-abs-reloc.s:2
+# RUN: llvm-mc -triple powerpc64le-unknown-linux-gnu %s -filetype=obj -o - | \
+# RUN:    llvm-objdump -D  -r - | FileCheck %s
+	.text
----------------
remove extra whitespace between `-D` and `-r`


================
Comment at: llvm/test/MC/PowerPC/ppc64-abs-reloc.s:3-15
+	.text
+test:                                   # @test
+	add 5, 3, 4
+	extsw 3, 5
+        .space 32776
+lab2:
+        lxv 5, (lab2-test)@l(4)
----------------
The indentation here looks like mixed usage of spaces and tabs. Let's pick one, and be consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115419/new/

https://reviews.llvm.org/D115419



More information about the llvm-commits mailing list