[PATCH] D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 11:14:55 PST 2022


rastogishubham updated this revision to Diff 402601.
rastogishubham added a comment.

In DwarfLinkerForBinary.cpp Line 475, we need to make sure that copySwiftReflectionMetadata is not called when the -no-output option is passed, this is because the DwarfStreamer object is not created, and copySwiftReflectionMetadata calls through to a member method of the DwarfStreamer Object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115007/new/

https://reviews.llvm.org/D115007

Files:
  llvm/include/llvm/BinaryFormat/Swift.def
  llvm/include/llvm/BinaryFormat/Swift.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/include/llvm/MC/MCContext.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/Object/MachO.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/lib/MC/MCContext.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/Object/MachOObjectFile.cpp
  llvm/test/tools/dsymutil/Inputs/main.yaml
  llvm/test/tools/dsymutil/Inputs/reflection_metadata.yaml
  llvm/test/tools/dsymutil/Inputs/test.yaml
  llvm/test/tools/dsymutil/X86/reflection-dump.test
  llvm/tools/dsymutil/DwarfLinkerForBinary.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115007.402601.patch
Type: text/x-patch
Size: 71881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220124/9ba4c522/attachment-0001.bin>


More information about the llvm-commits mailing list