[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

Mon Jan 24 09:22:06 PST 2022

xbolva00 added a comment.

In D116821#3266620 <https://reviews.llvm.org/D116821#3266620>, @jmorse wrote:

> Pushed up 74db5c8c95 <https://reviews.llvm.org/rG74db5c8c95e2aed40d288bb2df92eb859b87c827> that effectively reverts this patch, through disabling the on-by-default-for-x86 portion of code.
>
> I've dug through the CTMark SPASS sample and found some now-obvious problems. I reckon they can be addressed, but not immediately, so it's best to revert for the moment.
>
> This raises some uncertainty regarding the LLVM14 branch date; I'll post back here closer to the time.

You could default this option to just false, instead of ifdefing it out, so anybody could enable it explicitly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821