[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Mon Jan 24 09:03:39 PST 2022

craig.topper added a comment.

In D118011#3266014 <https://reviews.llvm.org/D118011#3266014>, @alextsao1999 wrote:

> In D118011#3265374 <https://reviews.llvm.org/D118011#3265374>, @Jimerlife wrote:
>
>> In D118011#3265071 <https://reviews.llvm.org/D118011#3265071>, @craig.topper wrote:
>>
>>> Will you also be updating clang's RISCVBuiltins.def?
>>>
>>> Can you add tests?
>>
>> I update BuiltinsRISCV.def and add "__builtin_riscv_clmul_kc" intrinsic for zbkc extension, but I am not sure if the name is  appropriate.
>
> https://github.com/rvkrypto/rvkrypto-fips/blob/main/rvkintrin.md
> Is the name as `__builtin_riscv_clmul_32` or `__builtin_riscv_clmul_64` better for conflict resolution?

The builtins for clmul have been in for months without _32 or _64 since they operate on the "long" data type.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118011/new/

https://reviews.llvm.org/D118011