[PATCH] D117768: [flang] Update flang wrapper on change.

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Hi @ygribov, thank you for this patch!

I think that it would make sense to update the summary of this change to e.g. `[flang][cmake] Add a custom target for the "flang" wrapper script`. This would more accurately reflect what this patch implements. Instead, the current description focuses on the side effects, i.e. that the script will be re-copied into the build dir whenever `{ninja|make} flang-wrapper` is run. Unless I misunderstood?

Thanks!



================
Comment at: flang/tools/f18/CMakeLists.txt:52
+    COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/flang ${CMAKE_BINARY_DIR}/bin)
+  add_custom_target(flang-wrapper ALL DEPENDS ${CMAKE_BINARY_DIR}/bin/flang)
   install(PROGRAMS ${CMAKE_BINARY_DIR}/bin/flang DESTINATION "${CMAKE_INSTALL_BINDIR}")
----------------
I think that it's a bit confusing if the name of the target and the generated tool are different. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117768/new/

https://reviews.llvm.org/D117768