[PATCH] D115873: [LAA] Add remarks for unbounded array access

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:565
+                       bool ShouldCheckWrap = false,
+                       Value **UncomputablePtr = nullptr);
 
----------------
Instead of passing in the pointer with a default value of `nullptr`, can you make it a reference, so that it always gets set, e.g.

  Value *&UncomputablePtr

That also removes the need for the conditional write.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll:200
 for.body.preheader:                               ; preds = %entry
-  br label %for.body, !dbg !35
+  br label %for.body, !dbg !32
 
----------------
Is this an unrelated change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115873/new/

https://reviews.llvm.org/D115873