[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

Mon Jan 24 04:15:13 PST 2022

nikic added a comment.

In D116821#3265685 <https://reviews.llvm.org/D116821#3265685>, @jmorse wrote:

> For memory consumption, I only observed negligible changes in max-rss when testing C++ codebases, CTMarks numbers for max-rss are roughly 1%.

Just a quick note on this: The max-rss numbers reported by the compile-time tracker are quite misleading in this case, because they add up max-rss from all compilations and the final link, while in this case only link memory usage increases. Here are the numbers from just the ReleaseLTO-g link steps:

  sqlite3.link 	191MiB 	195MiB (+2.26%)
  consumer-typeset.link 	155MiB 	155MiB (+0.07%)
  bullet.link 	208MiB 	207MiB (-0.04%)
  tramp3d-v4.link 	613MiB 	620MiB (+1.02%)
  pairlocalalign.link 	99MiB 	126MiB (+26.85%)
  clamscan.link 	213MiB 	216MiB (+1.23%)
  lencod.link 	257MiB 	275MiB (+6.90%)
  SPASS.link 	254MiB 	343MiB (+35.24%)
  7zip-benchmark.link 	439MiB 	442MiB (+0.67%)

The 25% and 35% increases on pairlocalalign and SPASS stand out as outliers here and might be good (relatively small) test cases to double check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821