[PATCH] D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

LGTM, I think. Craig's left more detailed feedback so I'll defer to him.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:948
+  case ISD::VP_GATHER:
+    SplitVecRes_Gather(cast<MemSDNode>(N), Lo, Hi, true);
     break;
----------------
`/*SplitSETCC*/ true`


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1940
+  SDValue Ptr = N->getBasePtr();
+  struct Operators {
+    SDValue Mask;
----------------
nit: `Operands` rather than `Operators`, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117760/new/

https://reviews.llvm.org/D117760