[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

WangLian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 00:59:06 PST 2022


Jimerlife added a comment.

In D118011#3265069 <https://reviews.llvm.org/D118011#3265069>, @kito-cheng wrote:

> Actually this patch is NOT NFC, you fixed an issue that is: `zbkc` isn't include `cmul` and `clmulh`.
>
> So I would suggest you:
>
> 1. Remove NFC from the title.
> 2. Add test case to test `cmul` and `clmulh` is available for `zbkc` after this patch.

Thank you. I adjust patch according your suggestions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118011/new/

https://reviews.llvm.org/D118011



More information about the llvm-commits mailing list