[PATCH] D117849: [docs] There are four bit storage containers.

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 15:37:03 PST 2022


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of comments inline.



================
Comment at: llvm/docs/ProgrammersManual.rst:2403
 
 Bit storage containers (BitVector, SparseBitVector, CoalescingBitVector)
 ------------------------------------------------------------------------
----------------
This should list `SmallBitVector` as well, right?


================
Comment at: llvm/docs/ProgrammersManual.rst:2406-2407
 
-There are three bit storage containers, and choosing when to use each is
+There are four bit storage containers, and choosing when to use each is
 relatively straightforward.
 
----------------
Is there a way of wording this to avoid having to update the count in the future? If not, LGTM as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117849/new/

https://reviews.llvm.org/D117849



More information about the llvm-commits mailing list