[PATCH] D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter

[Victor Perez via Phabricator via llvm-commits]

victor-eds added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2010
+  SDValue MaskLo, MaskHi;
+  if (Mask.getOpcode() == ISD::SETCC) {
+    SplitVecRes_SETCC(Mask.getNode(), MaskLo, MaskHi);
----------------
frasercrmck wrote:
> Is it possible to test this case?
I think it wasn't, but it doesn't apply anymore.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3038
+  SDValue MaskLo, MaskHi;
+  if (OpNo == 1 && Mask.getOpcode() == ISD::SETCC) {
+    SplitVecRes_SETCC(Mask.getNode(), MaskLo, MaskHi);
----------------
frasercrmck wrote:
> And test this, if possible.
Not sure if this applies anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117760/new/

https://reviews.llvm.org/D117760