[PATCH] D117778: [OpaquePtrs] Add -normalize-opaque-pointers option

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 10:33:23 PST 2022


aeubanks added a comment.

The issue with the opaque pointer migration is that passes sometimes don't handle them correctly, not that we can't print the final IR. This patch still doesn't test that passes properly handle both typed pointers and opaque pointers, unless the idea is that we'd have RUN lines with both `-opaque-pointers` and `-normalize-opaque-pointers` which this patch doesn't do for the modified tests.
As for a flag flip day, it would be per-frontend right? We can already incrementally update tests (including frontend e.g. clang) by adding `-opaque-pointers` to RUN lines.



================
Comment at: llvm/tools/opt/NewPMDriver.cpp:209
+    }
+    return PreservedAnalyses::all();
+  }
----------------
not really true when we remove instructions but it's the last pass so whatever


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117778/new/

https://reviews.llvm.org/D117778



More information about the llvm-commits mailing list