[PATCH] D117890: [LangRef] Require elementtype attribute for gc.statepoint intrinsic

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D117890#3261829 <https://reviews.llvm.org/D117890#3261829>, @reames wrote:

> What piece of code are you trying to remove?  I don't think we need this change unless I'm missing something.  The callee return type should already be encoded in the signature of the associated gc.result.

Yes, the callee return type is the important bit. Thanks for the suggestion on using the gc.result type for this purpose. Something I'm not quite clear on is whether a gc.statepoint with a non-void callee is required to also have a gc.result use? And if not, whether it is fine to simply lower the call with a void result instead?

> I definitely would not want this landing without the associated builder and test changes.

I'm mainly interested in feedback on the general direction here, before I spend a lot of time updating tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117890/new/

https://reviews.llvm.org/D117890