[PATCH] D117890: [LangRef] Require elementtype attribute for gc.statepoint intrinsic

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 09:38:35 PST 2022


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Generally sounds OK to me. (not sure what we do historically for these sort of changes - but I'd guess the documentation usually comes after the functionality (or in the same patch) rather than before - it might be relevant to see what test case cleanup looks like, etc, to evaluate the direction. But I don't mind too much - may be worth waiting to commit this until a few of the other patches in the series are available/reviewed)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117890/new/

https://reviews.llvm.org/D117890



More information about the llvm-commits mailing list