[PATCH] D117896: [LLD][ELF][AArch64] Update test with incorrect REQUIRES line [NFC]

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 08:30:28 PST 2022


peter.smith created this revision.
peter.smith added reviewers: MaskRay, ikudrin.
Herald added subscribers: kristof.beyls, emaste.
peter.smith requested review of this revision.

D54759 <https://reviews.llvm.org/D54759> introduced aarch64-combined-dynrel.s and aarch64-combined-dynrel-ifunc.s . Unfortunately the requires line at the top was AArch64 instead of aarch64 which means they were never run. Update the tests to use aarch64 and fix to match current lld output.


https://reviews.llvm.org/D117896

Files:
  lld/test/ELF/aarch64-combined-dynrel-ifunc.s
  lld/test/ELF/aarch64-combined-dynrel.s


Index: lld/test/ELF/aarch64-combined-dynrel.s
===================================================================
--- lld/test/ELF/aarch64-combined-dynrel.s
+++ lld/test/ELF/aarch64-combined-dynrel.s
@@ -1,4 +1,4 @@
-// REQUIRES: AArch64
+// REQUIRES: aarch64
 // RUN: llvm-mc --triple=aarch64-linux-gnu -filetype=obj -o %t.o %s
 // RUN: echo "SECTIONS { \
 // RUN:         .text : { *(.text) } \
@@ -32,6 +32,7 @@
 // CHECK-NEXT:         Type: SHT_RELA
 // CHECK-NEXT:     Flags [
 // CHECK-NEXT:       SHF_ALLOC
+// CHECK-NEXT:       SHF_INFO_LINK
 // CHECK-NEXT:     ]
 // CHECK-NEXT:     Address:
 // CHECK-NEXT:     Offset:
Index: lld/test/ELF/aarch64-combined-dynrel-ifunc.s
===================================================================
--- lld/test/ELF/aarch64-combined-dynrel-ifunc.s
+++ lld/test/ELF/aarch64-combined-dynrel-ifunc.s
@@ -1,4 +1,4 @@
-// REQUIRES: AArch64
+// REQUIRES: aarch64
 // RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %p/Inputs/shared.s -o %t-lib.o
 // RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %s -o %t.o
 // RUN: ld.lld %t-lib.o --shared -o %t.so
@@ -42,10 +42,11 @@
 // CHECK-NEXT:     Type: SHT_RELA
 // CHECK-NEXT:     Flags [
 // CHECK-NEXT:       SHF_ALLOC
+// CHECK-NEXT:       SHF_INFO_LINK
 // CHECK-NEXT:     ]
 // CHECK-NEXT:     Address:
 // CHECK-NEXT:     Offset:
 // CHECK-NEXT:     Size: 72
 
 // CHECK:      0x0000000000000008 RELASZ               72
-// CHECK:      0x0000000000000002 PLTRELSZ             48
+// CHECK:      0x0000000000000002 PLTRELSZ             24


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117896.401999.patch
Type: text/x-patch
Size: 1544 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220121/7223d79d/attachment.bin>


More information about the llvm-commits mailing list