[PATCH] D110450: [LLD] Remove global state in lld/COFF

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 21 05:17:09 PST 2022


aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

Thanks again Amy! LTGM with a note:



================
Comment at: lld/COFF/Driver.cpp:1293
     parallel::strategy = hardware_concurrency(threads);
-    config->thinLTOJobs = v.str();
+    ctx.config.thinLTOJobs = v.str();
   }
----------------
As an option, in this kind of long function, one could probably also create an alias at the top, if you want to avoid those many changes:
```
Config &config = ctx.config;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110450/new/

https://reviews.llvm.org/D110450



More information about the llvm-commits mailing list