[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

I ran into a regression with this patch, which triggers the error "fatal error: error in backend: unknown codeview register ST0" on code that built fine before that.

Here's a reduced reproducer:

  $ cat dither.c 
  a() {
    long double b;
    asm volatile("" : "=t"(b));
  }
  $ clang -target x86_64-w64-mingw32 -c -O2 -g -gcodeview dither.c 
  fatal error: error in backend: unknown codeview register ST0
  PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
  Stack dump:
  0.	Program arguments: bin/clang -target x86_64-w64-mingw32 -c -O2 -g -gcodeview dither.c
  1.	<eof> parser at end of file
  2.	Code generation
  3.	Running pass 'Function Pass Manager' on module 'dither.c'.
  4.	Running pass 'X86 Assembly Printer' on function '@a'

This makes it impossible to build VLC for x86_64 windows with PDB debug info, which worked fine before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821