[llvm] 1f9e18b - [llvm] Remove (some) LLVMDemangle header dependencies

[Serge Guelton via llvm-commits]

On Fri, Jan 21, 2022 at 10:47:12AM +0000, douglas.yung at sony.com wrote:
> Hi Serge,
> 
> I believe that your change is causing the build to fail on Visual Studio:
> 
> https://lab.llvm.org/buildbot/#/builders/119/builds/7327/steps/7/logs/stdio
> 
> FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/DLangDemangle.cpp.obj 
> C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\Demangle -Iinclude -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include -D__OPTIMIZE__ /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2    /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\DLangDemangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb /FS -c C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\Demangle\DLangDemangle.cpp
> C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Demangle/Utility.h(53): error C2440: 'initializing': cannot convert from 'std::_Array_iterator<_Ty,21>' to 'char *'
>         with
>         [
>             _Ty=char
>         ]
> C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Demangle/Utility.h(53): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
> C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Demangle/Utility.h(63): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'llvm::itanium_demangle::StringView'
> C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/Demangle/Utility.h(63): note: No constructor could take the source type, or constructor overload resolution was ambiguous
> 
> Can you take a look?

Should be fixed by 065044c443f4041f32e0a8d6e633f9d92580fbca