[PATCH] D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.

LGTM, just minor comments.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3397
 
+static bool isExtractHiElt(const MachineRegisterInfo &MRI, Register In,
+                           Register &Out) {
----------------
Not sure, but it might be cleaner to return Register (and return Register() on failure)?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3401
+  if (mi_match(In, MRI,
+               (m_GTrunc(m_GLShr(m_Reg(LShlSrc), (m_SpecificICst(16))))))) {
+    Out = LShlSrc;
----------------
Don't need the outermost parens on this line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117765/new/

https://reviews.llvm.org/D117765