[PATCH] D117778: [OpaquePtrs] Add -normalize-opaque-pointers option

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D117778#3260225 <https://reviews.llvm.org/D117778#3260225>, @dblaikie wrote:

> I think from that thread I still tend towards "introduce a build mode where it reads into opaque pointers (essentially auto-upgrade),

Flipping the `opaque-pointers` option to true is effectively that -- we should probably make that default controlled by a cmake option.

> either have a list of known-failing tests in this mode, or some other way to flag on a per-test basis (maybe start with a "passing" list, and eventually move to a "failing" list when that's smaller)" - but I don't feel especially strongly/open to others perspectives.

Looking at just Transforms tests, we have about 7k tests, of which 3k fail under opaque pointers, of which 0.5k crash. My primary concern here is that if we don't introduce something like this, we'll need to update 3k tests (in Transforms alone) during the opaque pointers switch. And we'll need to separately maintain those opaque-ified tests prior to the switch.

I think the more changes we can make prior to the atomic "flip the flag" commit, the better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117778/new/

https://reviews.llvm.org/D117778