[PATCH] D117778: [OpaquePtrs] Add -normalize-opaque-pointers option

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D117778#3259627 <https://reviews.llvm.org/D117778#3259627>, @nikic wrote:

> In D117778#3259584 <https://reviews.llvm.org/D117778#3259584>, @dblaikie wrote:
>
>> Could this be done by roundtripping through llvm-dis, rather than by having a builtin feature? (even if it can be done that way, not necessarily suggesting it's the better option - adding extra program executions will slow down tests especially on windows, etc - but curious/considering all the options, etc)
>
> This is actually what I originally proposed in https://reviews.llvm.org/D109290#2988806, and you suggested to integrate the option to save the extra program execution :) Another benefit of the option is that we can also drop the ptr to ptr bitcasts.

Ah, thanks for the context/reminder.

I think from that thread I still tend towards "introduce a build mode where it reads into opaque pointers (essentially auto-upgrade), either have a list of known-failing tests in this mode, or some other way to flag on a per-test basis (maybe start with a "passing" list, and eventually move to a "failing" list when that's smaller)" - but I don't feel especially strongly/open to others perspectives.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117778/new/

https://reviews.llvm.org/D117778