[PATCH] D117075: [AMDGPU][WQM] Set the lanes that should be deactivated with VCC.

Konstantina Mitropoulou via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 18:50:14 PST 2022


kmitropoulou marked an inline comment as done.
kmitropoulou added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/wqm.ll:2562
+; Check if the correct register is selected. WQM pass incorrectly uses VCC for vector comparisons in Wave32 mode. Make register selection wave size dependent.
+define amdgpu_ps void @test_for_deactivating_lanes_in_wave32(float addrspace(6)* inreg noalias align 4 dereferenceable(18446744073709551615) %0) #8 {
+; CHECK-WAVE32-LABEL: test_for_deactivating_lanes_in_wave32:
----------------
critson wrote:
> This can be reduced to:
> ```define amdgpu_ps void @test_for_deactivating_lanes_in_wave32(float addrspace(6)* inreg %0)```
> 
> and the associated attribute (8) removed without effecting code generation.
Thanks :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117075/new/

https://reviews.llvm.org/D117075



More information about the llvm-commits mailing list