[PATCH] D117794: [ISEL] Canonicalise constant splats to RHS.

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/AArch64/unfold-masked-merge-vector-variablemask-const.ll:132
 ; CHECK-NEXT:    ret
   %n0 = xor <4 x i32> <i32 -1, i32 -1, i32 -1, i32 -1>, %y ; %x
   %n1 = and <4 x i32> %n0, %mask
----------------
This appears to now produce the same codegen we get if this xor is commuted in the IR. So at least we're consistent now. So I don't think that should block this patch. I assume InstCombine would usually have commuted the Xor or folded this pattern to an Or anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117794/new/

https://reviews.llvm.org/D117794