[PATCH] D117354: [lld-macho] Allow order files and call graph sorting to be used together

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/SectionPriorities.cpp:379
+
+  // TODO: Make sure this handles weak symbols correctly.
+  for (const InputFile *file : inputFiles) {
----------------
lgrey wrote:
> oontvoo wrote:
> > nit: unless you're planning on taking care of this shortly - a bit more info on what to be done here would be helpful
> I moved this (with minor changes) from Writer.cpp, so I actually have no context on it! I left it in since int3@ (the original author) might still have ideas/plans for it, or at the least as a signpost that there might be an unhandled case (similar proved useful in  https://reviews.llvm.org/rGc4b45eeb44fdc49). Would it be better to delete?
Ah, ok - I guess let's  leave it here then. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117354/new/

https://reviews.llvm.org/D117354