[PATCH] D117745: issue-subscriber: Fix handling of labels with spaces

[Tom Stellard via Phabricator via llvm-commits]

tstellar updated this revision to Diff 401757.
tstellar added a comment.

Use environment variable for label name instead of disallowing apostrophes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117745/new/

https://reviews.llvm.org/D117745

Files:
  .github/workflows/issue-subscriber.yml


Index: .github/workflows/issue-subscriber.yml
===================================================================
--- .github/workflows/issue-subscriber.yml
+++ .github/workflows/issue-subscriber.yml
@@ -17,9 +17,12 @@
         pip install PyGithub
 
     - name: Update watchers
+      # https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
+      env:
+        LABEL_NAME: ${{ github.event.label.name }}
       run: |
         ./github-automation.py \
-          --token ${{ secrets.ISSUE_SUBSCRIBER_TOKEN }} \
+          --token '${{ secrets.ISSUE_SUBSCRIBER_TOKEN }}' \
           issue-subscriber \
-          --issue-number ${{ github.event.issue.number }} \
-          --label-name ${{ github.event.label.name }}
+          --issue-number '${{ github.event.issue.number }}' \
+          --label-name "$LABEL_NAME"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117745.401757.patch
Type: text/x-patch
Size: 900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220120/ee306c19/attachment.bin>