[PATCH] D116784: [ProfileData] Read and symbolize raw memprof profiles.

Thu Jan 20 11:07:44 PST 2022

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

In D116784#3258887 <https://reviews.llvm.org/D116784#3258887>, @snehasish wrote:

> In D116784#3256775 <https://reviews.llvm.org/D116784#3256775>, @tejohnson wrote:
>
>> Are you planning to rebase this on top of D117256 <https://reviews.llvm.org/D117256>?
>
> I was not planning on doing so. The changes which succeed this one evolve the MemInfoBlock data structure and aren't necessary to make this work. They are needed for the next patch which adds MemProfRecords to the indexed format. Do you see a particular advantage in having it the other way around?

Ah, I messed up the stack ordering of the patches. This seems fine. LGTM but please wait to see if @davidxl has any follow on comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116784/new/

https://reviews.llvm.org/D116784