[PATCH] D117354: [lld-macho] Allow order files and call graph sorting to be used together

Leonard Grey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 10:51:09 PST 2022


lgrey added inline comments.


================
Comment at: lld/MachO/SectionPriorities.cpp:253
 
+static Optional<size_t> getSymbolPriority(Defined& sym) {
+    if (sym.isAbsolute())
----------------
oontvoo wrote:
> you're not modifying the symbol
Done (but for my edification: why pointer to const vs. const ref?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117354/new/

https://reviews.llvm.org/D117354



More information about the llvm-commits mailing list