[PATCH] D88670: Reland rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking.

[Paweł Bylica via Phabricator via llvm-commits]

chfast added inline comments.


================
Comment at: llvm/test/tools/llvm-exegesis/X86/lbr/lit.local.cfg:21
           with open(os.devnull, 'w') as quiet:
-              check_llvm_exegesis_uops_result = subprocess.call(
-                [llvm_exegesis_exe, '-allowed-host-cpu', 'skylake', '-allowed-host-cpu', 'skylake-avx512', '-mode', 'uops', '-snippets-file', '/dev/null'], stdout=quiet, stderr=quiet)
               check_llvm_exegesis_latency_result = subprocess.call(
+                [llvm_exegesis_exe, '-mode', 'latency', '-x86-lbr-sample-period', '123', '-repetition-mode', 'loop', '-snippets-file', '/dev/null'], stdout=quiet, stderr=quiet)
----------------
This may be unrelated to this particular change, but this script hangs llvm-lit initialization. I'm using Python 3.9.

```
/llvm-project/llvm/utils/lit/lit/TestingConfig.py:103: fatal: unable to parse config file 'llvm-project/llvm/test/tools/llvm-exegesis/X86/lbr/lit.local.cfg', traceback: Traceback (most recent call last):
  File "llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 92, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "llvm-project/llvm/test/tools/llvm-exegesis/X86/lbr/lit.local.cfg", line 21, in <module>
    check_llvm_exegesis_latency_result = subprocess.call(
  File "/usr/lib/python3.9/subprocess.py", line 351, in call
    return p.wait(timeout=timeout)
  File "/usr/lib/python3.9/subprocess.py", line 1189, in wait
    return self._wait(timeout=timeout)
  File "/usr/lib/python3.9/subprocess.py", line 1917, in _wait
    (pid, sts) = self._try_wait(0)
  File "/usr/lib/python3.9/subprocess.py", line 1875, in _try_wait
    (pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88670/new/

https://reviews.llvm.org/D88670