[PATCH] D117703: [RISCV] Enable CGP to sink splat operands of VP intrinsics

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 07:01:53 PST 2022


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1282
+        // ... the one exception is vp.sub which has explicit patterns for both
+        // LHS and RHS (as vrsub).
+        case Intrinsic::vp_sub:
----------------
craig.topper wrote:
> Do we not handle frsub and frdiv?
Ah, yeah, sort of. We don't match them against non-true-masked intrinsics so I must have overlooked them in testing. I've opened D117783 to help keep `fsub` and `fdiv` to behave uniformly. I'd probably prefer to wait for that patch but it's probably not a big deal either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117703/new/

https://reviews.llvm.org/D117703



More information about the llvm-commits mailing list