[PATCH] D117575: [DebugInstrRef] Memoize variable order during sorting (NFC)

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 06:13:33 PST 2022


jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for find this!



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:2814
+    // We have to insert DBG_VALUEs in a consistent order, otherwise they
+    // appeaer in DWARF in different orders. Use the order that they appear
+    // when walking through each block / each instruction, stored in
----------------
nit, "appear"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117575/new/

https://reviews.llvm.org/D117575



More information about the llvm-commits mailing list