[PATCH] D117741: [RISCV] Set CostPerUse to 1 iff RVC is enabled

Thu Jan 20 05:54:36 PST 2022

luismarques added a comment.

In D117741#3257196 <https://reviews.llvm.org/D117741#3257196>, @pcwang-thead wrote:

> In D117741#3257026 <https://reviews.llvm.org/D117741#3257026>, @jrtc27 wrote:
>
>> This scheme seems rather inflexible. We can get away with it currently since the default behaviour of zero-filling CostPerUse elements out to the maximum list size works in every case, but I could see there being issues in future where you end up needing to be extremely verbose to avoid such behaviour.
>
> Correct me if I am wrong, we shall define CostPerUse=[0, 0] explicitly for RVC registers?

If I understand correctly, that would be enough to address @jrtc27's comment, no?

Overall LGTM. Maybe just clarify and address that previous point?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117741/new/

https://reviews.llvm.org/D117741