[PATCH] D116931: [GlobalISel][Legalizer] Support big endian when reducing load/store width

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 04:38:42 PST 2022


0x59616e added inline comments.


================
Comment at: llvm/test/CodeGen/M68k/GlobalISel/legalizer_load_store.ll:1
+; RUN: llc -mtriple=m68k -global-isel -stop-after=legalizer %s -o - | FileCheck %s
+
----------------
0x59616e wrote:
> arsenm wrote:
> > Generally legalizer tests are MIR->MIR. I think it would be best to have some end to end IR tests, in addition to MIR->MIR tests that only run the legalizer
> Do you mind explaining the meaning of "end to end IR tests" ?
Guess: If you mean  IR->assembly test, that needs instruction selector & regbank selector support, which I haven't started to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116931/new/

https://reviews.llvm.org/D116931



More information about the llvm-commits mailing list