[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

[Ties Stuij via Phabricator via llvm-commits]

stuij marked 2 inline comments as done.
stuij added inline comments.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:205
+AARCH64_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_RAS))
 AARCH64_CPU_NAME("cortex-x2", ARMV9A, FK_NEON_FP_ARMV8, false,
----------------
dmgreen wrote:
> Should this have the same features as the cortex-x1? AEK_DOTPROD and AEK_FP16 and the rest?
Yes, you're right. I've added these.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:983
+                                 FeatureNEON, FeaturePerfMon, FeatureSPE,
+                                 FeaturePAuth, FeatureFullFP16, FeatureFP16FML];
   list<SubtargetFeature> X2   = [HasV9_0aOps, FeatureNEON, FeaturePerfMon,
----------------
dmgreen wrote:
> Should this have dotprod and RCPC?
> 
> The TRM isn't super clear on what features are present. Is FP16FML present?
Right, the addition of FP16FML must have been copied from the X1, which was later removed when upstreaming. I removed it here, and I added dotard and RCPC. The only relevant change from X1 to X1C is the addition of PAUTH, as per the TRM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117202/new/

https://reviews.llvm.org/D117202