[PATCH] D117749: [lld-macho] Add support for -add_empty_section

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

>From the ld64 manpage:

  -add_empty_section segname sectname
             An empty section named sectname in the segment segname. If any of the inputs contains a section (segname,sectname), that section will be included in the output, and this option will be ignored.

Can we add a test for the case where the inputs also contain a section of the same name?



================
Comment at: lld/test/MachO/sectcreate.s:23
 
+# RUN: %lld -add_empty_section __foo __bar -o %t %t.o
+# RUN: llvm-readobj --sections %t | FileCheck --check-prefix=EMPTYSECTION %s
----------------
nit: I believe the double-underscore prefix is intended to be reserved for "special" section names, and user-created sections should just have regular un-prefixed names


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117749/new/

https://reviews.llvm.org/D117749