[PATCH] D117737: [lld][WebAssembly] Remove redundant config setting

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 18:20:53 PST 2022


sbc100 created this revision.
Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Unresolved symbols are not currently reported when building with
`-shared` or `-pie` so setting unresolvedSymbols doesn't have any
effect.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117737

Files:
  lld/wasm/Driver.cpp


Index: lld/wasm/Driver.cpp
===================================================================
--- lld/wasm/Driver.cpp
+++ lld/wasm/Driver.cpp
@@ -483,7 +483,6 @@
   if (config->shared) {
     config->importMemory = true;
     config->importUndefined = true;
-    config->unresolvedSymbols = UnresolvedPolicy::Ignore;
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117737.401469.patch
Type: text/x-patch
Size: 328 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220120/27e34ef8/attachment.bin>


More information about the llvm-commits mailing list